Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 support? #251

Open
Anonymous941 opened this issue Jul 6, 2022 · 24 comments
Open

1.19 support? #251

Anonymous941 opened this issue Jul 6, 2022 · 24 comments

Comments

@Anonymous941
Copy link

Is this project going to have support for Minecraft 1.19 in the future?

@MisterSoandSo
Copy link
Contributor

I might work out some time to get 1.19 patch over the weekend when I have time.

@Anonymous941
Copy link
Author

Anonymous941 commented Jul 7, 2022

Thank you, I've been spending hours trying to find a way to mod that version.

@Nonoreve
Copy link

Nonoreve commented Jul 8, 2022

Why closing this ? It might be good to have a feed to discuss 1.19 implementation and closing it once it is merged.

@MisterSoandSo
Copy link
Contributor

No idea why they closed this quick as I barely looked at new protocol scheme. I said I'd work on the update but not a guarantee update in the next few days.

@Nonoreve
Copy link

Nonoreve commented Jul 9, 2022

yea this is not a trivial task

@Anonymous941
Copy link
Author

No idea why they closed this quick as I barely looked at new protocol scheme. I said I'd work on the update but not a guarantee update in the next few days.

Sorry, I figured that you would implement it and there was no longer a need for this issue. I'll reopen it.

@Anonymous941 Anonymous941 reopened this Jul 9, 2022
@MisterSoandSo
Copy link
Contributor

MisterSoandSo commented Jul 9, 2022

image
One reason why 1.19 is annoying to update atm .... This is new chat message packet

@MisterSoandSo
Copy link
Contributor

image
Versus pre-1.18.2

@MisterSoandSo
Copy link
Contributor

yea this is not a trivial task

I want to cry internally after looking at the changes for both client and serverside packets

@Anonymous941
Copy link
Author

image One reason why 1.19 is annoying to update atm .... This is new chat message packet

Where is this picture from?

@MisterSoandSo
Copy link
Contributor

Where is this picture from?
https://wiki.vg/Protocol

@Anonymous941
Copy link
Author

Anonymous941 commented Jul 10, 2022

image One reason why 1.19 is annoying to update atm .... This is new chat message packet

Here's a modified version of the ChatPacket. I'll work on patching the other classes if I have some time.

@Anonymous941
Copy link
Author

I've added support for a few more serverbound types. It seems that this version introduces a lot more types of packets.

@MisterSoandSo
Copy link
Contributor

I've added support for a few more serverbound types. It seems that this version introduces a lot more types of packets.

This might help ...
https://github.com/MisterSoandSo/Minecraft-Packet-Protocol-Database

@Anonymous941
Copy link
Author

I've patched a few more classes, but I'm not sure I currently have the time to patch them all. If anyone wants to help, I can make you a collaborator on the fork.

@kotlinsyntax
Copy link

progress?

@MisterSoandSo
Copy link
Contributor

Bit busy IRL. This update has slowed down on my end.

@Anonymous941
Copy link
Author

Will there be any difference between 1.19 and 1.19.1? As far as I can tell, they just added reporting.

@MiniDigger
Copy link

the protocol changed, so yes.

@MisterSoandSo
Copy link
Contributor

At this point I believe 1.19+ warrants complete overhaul as

  1. Mojang auth is depreciated. You need to the Microsoft/xbox login ... Doable but not published in pycraft
  2. Chat packet is needs revamping
  3. Proposal: A better updating scheme for packet number as this affects maintainability in the long run

@Anonymous941
Copy link
Author

At this point I believe 1.19+ warrants complete overhaul as

1. Mojang auth is depreciated. You need to the Microsoft/xbox login ... Doable but not published in pycraft

2. Chat packet is needs revamping

3. Proposal: A better updating scheme for packet number as this affects maintainability in the long run

You can see my fork for a modified version of the ChatPacket and a few more classes.

@kotlinsyntax
Copy link

interesting

@Anonymous941
Copy link
Author

interesting

What do you mean?

@C2Coder
Copy link

C2Coder commented Dec 21, 2022

I don´t know it this helps, but i found a python library that implements minecraft protocot.

https://github.com/barneygale/quarry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants