[duktape] upgrade to duktape 2.3.0 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failures seem to indicate this PR does not work as I intended. 😢 |
|
I'm not sure how to fix the stdint.h on windows portion just yet, it looks like VS9 doesn't have stdint.h header. I was looking into the log for duktape but haven't finished yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an upgrade to dukpy 2.3.0 (from 1.4.0) which has some performance gains (25% or so in simple testing). I built with
python setup.py buildandpython setup sdist buildand tried to remove all compile errors.I am unsure about the changes in _support.c (the two void ptrs added),
but more confident in the others.How can I run tests for dukpy? Any feedback / help appreciated.[TESTPLAN] build dukpy and install it, check performance difference on simple JSX files, verify new version of dukpy loads in python REPL.