Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Countermeasure against replay attack #152

Closed
Lbird opened this issue Oct 25, 2019 · 2 comments
Closed

Countermeasure against replay attack #152

Lbird opened this issue Oct 25, 2019 · 2 comments
Assignees
@h0n9
Labels
feature New feature or request
Milestone
v1.3

Comments

@Lbird
Copy link
Contributor

Lbird commented Oct 25, 2019 •
edited by h0n9
Loading

to implement:

  • record txs included in blocks
  • ignore(or remove) too old tx
  • in checkTx(), check if tx is already included in block

to consider:

  • how to bind tx to block height
  • how to prevent malicious users abusing binding txs
@Lbird Lbird added the feature New feature or request label Oct 25, 2019
@Lbird Lbird added this to the v1.3 milestone Nov 12, 2019
@Lbird
Copy link
Contributor Author

Lbird commented Nov 14, 2019

This is necessary due to the tendermint issue tendermint/tendermint#3865. The issue harms overall performance.

@h0n9
Copy link
Contributor

h0n9 commented Nov 18, 2019

https://docs.tendermint.com/app-dev/app-development.html#replay-protection could be helpful

@h0n9 h0n9 mentioned this issue Nov 21, 2019
Closed
@h0n9 h0n9 self-assigned this Nov 28, 2019
@h0n9 h0n9 closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h0n9 h0n9

Labels
feature New feature or request
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
2 participants
@Lbird @h0n9