Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conditional Monitoring #20

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Add Conditional Monitoring #20

merged 3 commits into from
Oct 1, 2021

Conversation

flavio-fernandes
Copy link
Contributor

@flavio-fernandes flavio-fernandes commented Sep 24, 2021 •
edited
Loading 

Add support for monitoring specific tables

With this change, caller can choose what tables she/he cares to
monitor by using 2 optional flags:

  -monitor string
        Only monitor these comma-separated tables
  -no-monitor string
        Do not monitor these comma-separated tables

The table names provided are not case sensitive.
If none of these 2 parameters are used, all tables are monitored.

To monitor all tables, except Connection and NB_Global:

   ovsdb-mon --db "tcp:${PODIP}:6641" -auto -no-monitor Connection,nb_global

To only monitor NAT table:

   ovsdb-mon -monitor nat

Fixes: #18

@flavio-fernandes
Upgrade github.com/ovn-org/libovsdb and ovn schemas
10a864e 
From github.com/ovn-org/libovsdb v0.6.1-0.20210803142447-94fe2cdc514e
To   github.com/ovn-org/libovsdb v0.6.1-0.20210920174042-03e0010e3257

OVN NB from 5.32.0 to 5.32.1
OVN SB 20.20.0 with SB_Global controller_meter

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
@flavio-fernandes flavio-fernandes force-pushed the cond_monitor branch 2 times, most recently from c5ad0e1 to 867780b Compare September 24, 2021 14:29
@flavio-fernandes
Copy link
Contributor Author

PTAL :)
/assign @amorenoz @halfcrazy

@amorenoz
Copy link
Owner

Thanks @flavio-fernandes!

@flavio-fernandes
Add support for monitoring specific tables
6cda108 
With this change, caller can choose what tables she/he cares to
monitor by using 2 optional flags:

  -monitor string
        Only monitor these comma-separated tables
  -no-monitor string
        Do not monitor these comma-separated tables

The table names provided are not case sensitive.
If none of these 2 parameters are used, all tables are monitored.

To monitor all tables, except Connection and NB_Global:

   ovsdb-mon --db "tcp:${PODIP}:6641" -auto -no-monitor Connection,nb_global

To only monitor NAT table:

   ovsdb-mon -monitor nat

Fixes: amorenoz#18
@amorenoz
Copy link
Owner

amorenoz commented Oct 1, 2021

I love the feature @flavio-fernandes, thanks so much.
I have only one request. Would you kindly update the README.md to expose this new feature?
Apart from that LGTM

@amorenoz
Copy link
Owner

amorenoz commented Oct 1, 2021

Darn! you already have :-D

@amorenoz amorenoz merged commit b1f0edb into amorenoz:main Oct 1, 2021
@amorenoz amorenoz changed the title Cond monitor Add Conditional Monitoring Oct 1, 2021
@amorenoz amorenoz added the feature New feature or request label Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Conditional Monitoring support
2 participants
@flavio-fernandes @amorenoz