Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Bf file type support #3

Closed
wants to merge 1 commit into from

Conversation

harlequinzeg0
Copy link

adding .BF file block types

adding .BF file block types
@amorilia
Copy link
Owner

Thanks for the patch! Just two questions:

  1. I don't see anything wrong with the xml right away - however, this doesn't concern the nif format at all, or does it? If so, then wouldn't it be better to maintain the format in a separate xml file (in a separate git repository? For example, we already have a separate repository for the kfm format:

    https://github.com/amorilia/kfmxml

    In other words: is there any compelling reason to keep these definitions inside of nif.xml?

  2. I guess the format could be added to pyffi so it could be edited with QSkope. How are you currently using this code to edit the files?

@harlequinzeg0
Copy link
Author

in answer to the first question, its an animation file type modified from the KF filetype using compression so i would assume it'd fit under the nif format however if you want to add support for it as a seperate xml i'll need some help setting that up : P

2, im using this code to manually convert KF's into BFs in nifskope by copying the needed rotation data and such into the BF equivalent data blocks, then i save it as a KF file since i cant save it as a BF file. i then remove the header strings from it using a hex editor since BF files dont have a header saying its file version and block array. it'd be easier to add its own support if it had new basic values i was asking for on the forums : P

@amorilia
Copy link
Owner

Interesting method. :-)

This isn't what I would recommend an average user. For the time being, I would suggest that you maintain your own xml until we have a proper bf editor. Since, format-wise, bf has no overlap with nif, eventually this probably belongs better in its own xml.

The xml description is at this moment in process of being revised, and one of the items on the agenda is indeed to allow specification of more basic types. I'll leave this pull request open and post back here as we come closer to our goal - it may take a while though.

@harlequinzeg0
Copy link
Author

that is fine, our modding community shall continue to keep our private copy of the xml till nifskope can better integrate the BF format :) be sure to message me when we can work on that :D

@amorilia
Copy link
Owner

Yes, of course. One feature that nifskope should have is the possibility to include "foreign" xml files - that way you don't need to remerge with nif.xml on every nifskope update. I'll have a look at adding such feature.

@harlequinzeg0
Copy link
Author

that should hopefully be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants