User live score

[johnmadden86]

tests still to be done

[amosbastian]

All map and filter can be replaced by list comprehensions. Still need a solution for returning dictionaries breaking the previous version's code. Some other small changes as well, but this is what I had time to check for today.

[gringorichards]

This feature to give us the user live score is great, I'm looking forward to it :)

[amosbastian]

I think you mentioned one of the reasons of returning dictionaries instead of lists was because it necessary for something you were going to implement, right? Could you point me to where exactly so I can see if there is a possible solution?

[johnmadden86]

It's convenient as opposed to strictly necessary
e.g.
first_xi_live_scores = [players[player_id].live_score for player_id in first_xi]
here i can access the correct player directly just by calling the id, instead of performing an iteration

An alternative to be to make a "find" helper function that does this iteration.

Haven't looked at this for a a few days, but I was trying to tidy up my branches and make my master branch closer to yours so it'd be easier to merge. I had reverted to using lists for this - going to keep the dict returns in a separate branch - should eventually get it cleaned up properly
Take a look at my master branch and see how different it is now after my most recent push

[johnmadden86]

def find(items, id_): try: return items[id_] except KeyError: return next(item for item in items if item["id"] == id_)

This as a utility function would work for either dicts or lists
I'm not sure which is faster