Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong download value in the attributes #26

Closed
neuroverflow opened this issue Jan 30, 2022 · 2 comments
Closed

Wrong download value in the attributes #26

neuroverflow opened this issue Jan 30, 2022 · 2 comments

Comments

@neuroverflow
Copy link

Hi!
I noticed you send twice the upload instead of sending the download.
Units seems to to bauds, can we convert them to ko/s or mo/s?

@property def extra_state_attributes(self): """Return extra state attributes.""" return { "connection_type": self._client.connection_type, "interface": self._client.interface, "down_kb_per_s": self._client.up_kb_per_s, "up_kb_per_s": self._client.up_kb_per_s, }

@mogodon
Copy link

mogodon commented Jan 30, 2022

Was just about to post this
deco
.

amosyuen added a commit that referenced this issue Jan 31, 2022
* Use bytes instead of bits
* Rename kb_per_s to kilobytes_per_s to make the units more clear
amosyuen added a commit that referenced this issue Jan 31, 2022
* Use bytes instead of bits
* Rename kb_per_s to kilobytes_per_s to make the units more clear
@amosyuen
Copy link
Owner

Fixed in v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants