Use TARGET_FILE in ctlrender unittest. Fixes #45.

[cbenhagen]

No description provided.

[aforsythe]

Ben.

Thanks. I'll test shortly and I all goes well merge.

Alex

On May 26, 2014, at 3:56 PM, "Ben Hagen" <notifications@github.commailto:notifications@github.com> wrote:

---

You can merge this Pull Request by running

git pull https://github.com/cbenhagen/CTL fix#45

Or view, comment on, or merge it at:

#46

Commit Summary

• Use TARGET_FILE in ctlrender unittest. Fixes ctlrender unittest fails on OSX #45.

File Changes

• M unittest/ctlrender/CMakeLists.txthttps://github.com/Use TARGET_FILE in ctlrender unittest. Fixes #45. #46/files#diff-0 (2)
• M unittest/ctlrender/test.shhttps://github.com/Use TARGET_FILE in ctlrender unittest. Fixes #45. #46/files#diff-1 (7)

Patch Links:

• https://github.com/ampas/CTL/pull/46.patch
• https://github.com/ampas/CTL/pull/46.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/46.

[Δ]http://www.oscars.org

Alex Forsythe
Image Engineering Manager

Academy of Motion Picture Arts and Sciences
Science & Technology Council
1313 Vine Street • Hollywood, CA 90028

323.817.4170 • aforsythe@oscars.orgmailto:aforsythe@oscars.org

[aforsythe]

@cbenhagen Still appears to be failing for me. First 3 tests pass if I use sudo, but last always fails.

https://gist.github.com/aforsythe/8ece55215b091d86c99d

Am I missing something?

On May 26, 2014, at 3:56 PM, Ben Hagen notifications@github.com wrote:

You can merge this Pull Request by running

git pull https://github.com/cbenhagen/CTL fix#45
Or view, comment on, or merge it at:

#46

Commit Summary

  • Use TARGET_FILE in ctlrender unittest. Fixes #45.

File Changes

  • M unittest/ctlrender/CMakeLists.txt (2)
  • M unittest/ctlrender/test.sh (7)

Patch Links:

  • https://github.com/ampas/CTL/pull/46.patch
  • https://github.com/ampas/CTL/pull/46.diff

—
Reply to this email directly or view it on GitHub.

Alex Forsythe
Image Engineering Manager
Academy of Motion Picture Arts and Sciences
1313 Vine Street Hollywood CA 90028
323.817.4170 mailto:aforsythe@oscars.org

[cbenhagen]

Ummh that's strange. Can you show me the content of unittest/Testing/Temporary/LastTest.log?

[aforsythe]

Looks like a path issue ...

Here's the result of running make check
https://gist.github.com/aforsythe/1e827a9b6f5f2ab2f2c0

And the result of running sudo make check
https://gist.github.com/aforsythe/8b0563ccf98e7dd641f4

[cbenhagen]

so where is your ctlrender binary?

[aforsythe]

I see the problem. It wasn't there because it doesn't get built when I run make check. I had to run make first. Still getting exceptions on tests 1 and 3 without sudo, but now 4 passes. All tests pass with sudo make check.

[cbenhagen]

Cool so lets merge this and open another issue for the sudo problem. I can run all the tests without sudo here and i think you should never have to use sudo for tests.

[aforsythe]

Agreed! Thanks for the help

[cbenhagen]

You're welcome! Would you mind creating a 1.5.1 release with this fix? So i could finish the homebrew formula update?

[aforsythe]

Done!!

[aforsythe]

Will it mess anything up with the brew script if I merge #44 and move the 1.5.1 tag?

[cbenhagen]

It would mess up the shasum of the release tarball but thats ok if you do it now 👍

[aforsythe]

Give me just a couple of mins to update the documentation. I'll include new notes on how to install CTL via homebrew in the README.

Alex

On May 27, 2014, at 8:50 AM, Ben Hagen notifications@github.com wrote:

It would mess up the shasum of the release tarball but thats ok if you do it now

—
Reply to this email directly or view it on GitHub.

Alex Forsythe
Image Engineering Manager
Academy of Motion Picture Arts and Sciences
1313 Vine Street Hollywood CA 90028
323.817.4170 mailto:aforsythe@oscars.org

[aforsythe]

Ok ...

I think we are good to go.

Alex

On May 27, 2014, at 8:50 AM, Ben Hagen notifications@github.com wrote:

It would mess up the shasum of the release tarball but thats ok if you do it now

—
Reply to this email directly or view it on GitHub.

Alex Forsythe
Image Engineering Manager
Academy of Motion Picture Arts and Sciences
1313 Vine Street Hollywood CA 90028
323.817.4170 mailto:aforsythe@oscars.org