Wrong defer watcher try / catch

[kelunik]

amp/lib/Loop/Driver.php

Line 112 in 8f903b6

$result = $callback($watcher->id, $watcher->data);

should have the try / catch around the $callback invocation, not around the foreach.

[trowski]

That try / catch block catches exceptions thrown from any watcher invocation, not just defers, as it is also around the call to dispatch. Any watcher callback throwing an exception effectively immediately ends the tick. In this way defers are handled the same as any other watcher.

[kelunik]

It makes handling easier, but it won't execute any I/O watchers if there's always one defer throwing.

[trowski]

I can't imagine that happening in an actual app.

[kelunik]

Same here, that'd be an extreme edge case, but it might happen, as we use Loop::defer to rethrow errors from promises.

[bwoebi]

I see no reason why this shouldn't be changed...

[trowski]

@bwoebi After thinking about this, I realized an app might have a IO, timer, or signal that continually throws that might block another watcher from ever executing that would stop the cycle. I'll update everywhere watcher callbacks are invoked to be wrapped by their own try / catch blocks and continue the tick after calling the loop error handler.