Attempt direct read on ResourceInputStream::read() #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That also solves #21 I think. |
|
It still hangs with that PR. |
|
Closing for now. |
This change should resolve the low performance on Windows' STDIN. STDIN on Windows is a file handle and Windows has specialized support built into it's stream_select implementation, but a stream_select with a file handle takes 100ms, which results in slow performance if we read in smaller chunks and always have to wait 100ms between these. Fixes amphp/socket#52.
kelunik
force-pushed
the
fix-artax-issue-138
branch
from
b30e69b
to
b5f22cc
Compare
This was referenced Mar 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect the read buffer is filled by OpenSSL in another I/O operation and then the stream is never marked readable again, because the readable data is already in PHP's buffer space. An instant read attempt solves this by always ensuring the read buffer is completely empty.
/cc @brstgt @bwoebi @trowski