Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web SAPI input/output stream getter functions #61

Merged
merged 4 commits into from
Jun 3, 2019
Merged

Add web SAPI input/output stream getter functions #61

merged 4 commits into from
Jun 3, 2019

Conversation

danog
Copy link
Contributor

@danog danog commented May 21, 2019 •
edited
Loading

As usual, a release would be nice <3

@kelunik kelunik requested a review from trowski May 21, 2019 16:20
kelunik
kelunik reviewed May 21, 2019
View reviewed changes
Copy link
Member

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the names of the functions, but don't have an immediate better suggestion.

@danog
Copy link
Contributor Author

danog commented May 22, 2019

Niether do I, maybe getBufferInput/getBufferOutput?

kelunik
kelunik reviewed Jun 3, 2019
View reviewed changes
lib/functions.php
$stream = Loop::getState($key);

if (!$stream) {
$stream = new ResourceOutputStream(\fopen('php://output', 'w'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be wb?

@kelunik kelunik changed the title Add web input/output stream getter functions Add web SAPI input/output stream getter functions Jun 3, 2019
@kelunik kelunik merged commit d8cc314 into amphp:master Jun 3, 2019
@kelunik
Copy link
Member

kelunik commented Jun 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik approved these changes

@trowski trowski trowski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danog @kelunik @trowski