Add support for Windows DNS nameserver configuration #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the default Google nameservers, as they were only required for Windows. Fixes #38.
|
@kelunik, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bwoebi, @rdlowrey and @DaveRandom to be potential reviewers. |
|
I added the default servers back, but issue a deprecation warning instead now. That allows creating a minor release now and removing them in the next major release. I don't want to change all packages now to upgrade to a new major for that one. |
staabm
reviewed
Jan 4, 2017
| $reader = new WindowsRegistry; | ||
| $nameserver = null; | ||
|
|
||
| while ($key = array_shift($keys)) { |
bwoebi
requested changes
Jan 4, 2017
|
@bwoebi Every known system should work now. If there's one that doesn't work, we should be made aware of it and fix it. A broken config should error, not simply send all your DNS queries to Google. |
Closed
bwoebi
approved these changes
Jan 4, 2017
|
Args, a bit too fast... |
peter279k
pushed a commit
to peter279k/dns
that referenced
this pull request
Dec 7, 2020
Alpine doesn't have dig by default. Thought I'd add it to the doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the default Google nameservers, as they were only required for Windows.
Fixes #38.