-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove amphp/file and amphp/uri dependencies #80
Conversation
Allows easy drop in replacement of async reader.
Forgot about also removing |
I will need to test these, but I have a feeling this is going to make it much more stable \o/ I am not entirely sure yet about the name here though. Maybe |
@PeeHaa I think you're right that 'blocking' is more clear, so I renamed |
Replaces async loading of hosts and resolver files with blocking reads by default. An async file loader is also provided.
HostLoader
is now an interface, therefore is a BC break, though likely would not affect most users.The third commit uses the async loader by default if
amphp/file
is installed. Thoughts?Closes #78.