Add connect context arg to Connection::connect() #82
Conversation
|
Looks good to me. I didn't check for postgres, maybe it's the same problem there? Can you also add a test? |
src/TimeoutConnector.php
Outdated
| @@ -30,14 +29,6 @@ public function __construct(int $timeout = self::DEFAULT_TIMEOUT) | |||
| */ | |||
| public function connect(SqlConnectionConfig $config): Promise | |||
| { | |||
| if (!$config instanceof ConnectionConfig) { | |||
| throw new \TypeError(\sprintf("Must provide an instance of %s to MySQL connectors", ConnectionConfig::class)); | |||
| } | |||
There was a problem hiding this comment.
This shouldn't have been dropped I guess?
There was a problem hiding this comment.
Yeah, I was a little overzealous with the delete key.
|
@kelunik @prolic I don't think this is a problem in postgres since that library uses loop watchers for connection due to how the extensions work. |
|
Shouldn't TimeoutConnector gain that new context arg as well? |
|
Potentially, but I think it would be better to add another class such as |
|
Any reason why this has not been merged? |
Addresses #81.