Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cron job and workflow dispatch triggers to CI workflow #94

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Added cron job and workflow dispatch triggers to CI workflow #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
name: Continuous Integration

on:
- push
- pull_request
push:
pull_request:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See PR description.

schedule:
- cron: 0 6 * * *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a cron?

Copy link
Contributor Author

@Bilge Bilge Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this was last tested 7 months ago and it is set up to build against the latest version of Redis, which is moving forwards over time, so this will alert you if an incompatibility arises going forward. Moreover, since there is no composer.lock, all the libraries can change, as is the case presently, since CI is failing with Psalm errors which were unknown until someone tried to create a PR. For either, but especially both of these reasons, we should have a daily cron. It's not like it costs you anything, so I don't see a downside.


jobs:
tests:
Expand Down
Loading