Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Moves from optparse to argparse #34

Open
wants to merge 2 commits into
base: branch-2.0
Choose a base branch
from

Conversation

thisisdhaas
Copy link
Member

See https://docs.python.org/2.7/library/argparse.html#upgrading-optparse-code for a checklist of things that should have been done (which I tried to follow), and http://stackoverflow.com/questions/3217673/why-use-argparse-rather-than-optparse for a discussion of why this is a good idea in general.

See #26 for a discussion of dropping support for python 2.6 in spark-ec2 2.0

@shivaram
Copy link
Contributor

Thanks @thisisdhaas - Change mostly LGTM. One thing is that it would be good to change the README to note that we require python 2.7 from here on

cc @nchammas

@nchammas
Copy link
Contributor

Didn't test it out, but the changes LGTM.

And yes, the README should make it loud and clear that we've dropped Python 2.6 support. Better would be to capture that in code somehow, so the error when someone runs on 2.6 is clean, but a README note is good enough IMO.

@shivaram shivaram mentioned this pull request Jul 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants