Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

--spark-ec2-compressed option added. #42

Open
wants to merge 1 commit into
base: branch-1.6
Choose a base branch
from

Conversation

ar-ms
Copy link

@ar-ms ar-ms commented Jul 21, 2016

Description

--spark-ec2-compressed option enables to precise a compressed version of spark-ec2. This option is an alternative to cloning spark-ec2 from GitHub.

Accepted compression format

.tar, .tar.gz, .tar.bz2, .tar.xz

@shivaram
Copy link
Contributor

Could you explain the motivation for this change ?

@ar-ms
Copy link
Author

ar-ms commented Jul 25, 2016

I worked for a company that has a private GitLab, it was useful to me to have this feature because I cannot access the GitLab from the outside.

It could be nice to have an alternative to GitHub, if there is any problem with GitHub or the repository, you could continue to deploy cluster without wasting time.

@shivaram
Copy link
Contributor

Hmm - but the git clone here is happening on the master machine -- Is the assumption that the master machine cannot access artifacts from the public internet ? In that case a lot of other things like installing Spark or HDFS will also fail ?

@ar-ms
Copy link
Author

ar-ms commented Jul 28, 2016

It doesn't assume the situation where the master has no access to the Internet.

But those cases:

@shivaram
Copy link
Contributor

In that case can we simplify this and just take a URL to a tgz that can be used to do wget on the master ? It will simplify the code more and even github has urls of the form https://github.com/amplab/spark-ec2/archive/branch-1.6.zip

@ar-ms
Copy link
Author

ar-ms commented Jul 29, 2016

Super idea 👍 ! So we can remove git clone and rsync, and replace them by a simple wget ?

@shivaram
Copy link
Contributor

To be more conservative I'd make the zip file path a command line option and if the option is present, we can use wget. If not it'll still use the existing code path

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants