Skip to content

fix(cookies): reduce cookie lifetime #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2020
Merged

fix(cookies): reduce cookie lifetime #306

merged 3 commits into from
Nov 5, 2020

Conversation

kelvin-lu
Copy link
Contributor

@kelvin-lu kelvin-lu commented Oct 6, 2020 •
edited
Loading

Summary

Resolves issue #275 - reduce the cookie expiration to only 1 year to be GDPR compliant by default.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

jooohhn
jooohhn approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@jooohhn jooohhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelvin-lu kelvin-lu merged commit 84e1a57 into master Nov 5, 2020
@kelvin-lu kelvin-lu deleted the 273/cookie-life branch November 5, 2020 05:48
github-actions bot pushed a commit that referenced this pull request Nov 5, 2020
@amplitude-sdk-bot
chore(release): 7.3.2 [skip ci]
043a3ce 
## [7.3.2](v7.3.1...v7.3.2) (2020-11-05)

### Bug Fixes

* **cookies:** reduce cookie lifetime ([#306](#306)) ([84e1a57](84e1a57))
* Prototype js fix ([#313](#313)) ([7e463ab](7e463ab))
@github-actions
Copy link

github-actions bot commented Nov 5, 2020

🎉 This PR is included in version 7.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jooohhn jooohhn jooohhn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelvin-lu @jooohhn