Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-ssr] Promisify the API #7

Closed
andreban opened this issue Jan 15, 2018 · 0 comments
Closed

[amp-ssr] Promisify the API #7

andreban opened this issue Jan 15, 2018 · 0 comments
Labels
enhancement

Comments

@andreban
Copy link
Member

Change the Transformer API to return Promises. This is in order enable the transformation to run asynchronously, and will prepare the API for transformations that require I/O operations, for instance.
sebastianbenz added a commit to sebastianbenz/amp-toolbox that referenced this issue Jan 15, 2018
@sebastianbenz
Support transformers returning promises
a9a756b 
Fixes ampproject#7

Change-Id: I1101e70e85290df209e2f57f1120e370a43ac060
@sebastianbenz sebastianbenz mentioned this issue Jan 15, 2018
Merged
andreban pushed a commit to andreban/amp-toolbox that referenced this issue Jan 17, 2018
@sebastianbenz @andreban
Support transformers returning promises
bb51555 
Fixes ampproject#7

Change-Id: I1101e70e85290df209e2f57f1120e370a43ac060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreban