Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure before/after is amended to filtered comment_reply_link #1118

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented May 4, 2018

The \get_comment_reply_link() function returns with:

return apply_filters( 'comment_reply_link', $args['before'] . $link . $args['after'], $args, $comment, $post );

Currently when we re-construct the $link we're not adding the before/after args in AMP_Theme_Support::filter_comment_reply_link() when returning:

https://github.com/Automattic/amp-wp/blob/2328f71ea256640d6bb2c6122e11e5aab6afa499/includes/class-amp-theme-support.php#L774-L781

So we need to ensure that the before/after text is added.

@westonruter westonruter added this to the v0.7.1 milestone May 4, 2018

@westonruter westonruter force-pushed the fix/comment-reply-link-before-after branch from 450e234 to 0efb634 May 5, 2018

@westonruter westonruter requested a review from kienstra May 5, 2018

@amedina

amedina approved these changes May 5, 2018

Copy link
Member

left a comment

LGTM!

@westonruter westonruter merged commit f7dcbfd into 0.7 May 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/comment-reply-link-before-after branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.