[WIP] Add AMP_Script_Sanitizer to automatically detect and replace known scripts #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amedina
changed the title
…medina/fix-1032
|
Hi @amedina, this is a great idea and should help many sites as they enable AMP! Thanks for sharing this PR. |
|
Just stumbled upon this and realized that the Site Kit plugin has similar script detection for Google Analytics and Google Tag Manager. So there is some overlap at the moment. |
|
@swissspidy I don't think this is going to go anywhere, since it is not scalable. Better to let Site Kit and other plugins focus on their respective domains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress users very commonly add script tags to Custom HTML widgets and directly to theme templates to show ads, add analytics, etc. Assuming that the vast majority of these scripts are very templated (e.g. including via Google Tag Manager), then it should be possible to reliably identify each script and extract the relevant information to convert to AMP. This pull request addresses this.
Fixes #1032