New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obtaining source for widgets #1212

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Jun 14, 2018

I noticed when testing validation errors raised by the Jetpack Google Translate widget that it was erroneously reporting core and wp-includesas the source, along with a superfluous reflection property:

    {
        "reflection": {
            "name": "display_callback",
            "class": "WP_Widget"
        },
        "type": "core",
        "name": "wp-includes",
        "function": "Jetpack_Google_Translate_Widget::display_callback",
        "widget_id": "google_translate_widget-2",
        "handle": "google-translate"
    }

After this change, the source appears properly as:

    {
        "type": "plugin",
        "name": "jetpack",
        "function": "Jetpack_Google_Translate_Widget::display_callback",
        "widget_id": "google_translate_widget-2",
        "handle": "google-translate"
    }

@westonruter westonruter added this to the v1.0 milestone Jun 14, 2018

@westonruter westonruter requested a review from kienstra Jun 14, 2018

@westonruter westonruter force-pushed the fix/widget-source branch from a534804 to b811dca Jun 14, 2018

@amedina

LGTM.

@westonruter westonruter merged commit 014e0a0 into develop Jun 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/widget-source branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment