Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to post list table in case of admin bar validate request failure #1229

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

westonruter commented Jun 26, 2018

Fixes issue when clicking the Validate URL link in the admin bar:

image

Whereby if there is an HTTP request error the plugin currently redirects back to the page with query vars added to it (and no other indication of an error):

/?amp_validate_error=http_request_failed&amp_urls_tested=0

When instead it should redirect to the post list table:

image

@westonruter westonruter added this to the v1.0 milestone Jun 26, 2018

@westonruter westonruter requested a review from kienstra Jun 26, 2018

@kienstra
Copy link
Collaborator

kienstra left a comment

Approved

Hi @westonruter,
This looks good, and it's nice to have that notice when there's a failed request. Thanks for the nice screenshots, as usual 😄

@westonruter westonruter merged commit 18093fa into develop Jun 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/admin-bar-validate-url-request-failure branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.