Fix parsing CSS selectors which contain commas #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue where a CSS selectors would fail to parse correctly when they contain commas. For example:
There should only be one selector here:
.widget:not(.widget_text, .jetpack_widget_social_icons) ul
. Instead, the parser incorrectly extracts two:.widget:not(.widget_text
.jetpack_widget_social_icons) ul
The fix is to add placeholders for expressions contained in parentheses or brackets prior to splitting, and then replace the placeholders with their original values on the split selectors.
This PR updates the PHP-CSS-Parser to the state of the library with this upstream PR merged: MyIntervals/PHP-CSS-Parser#138
This PR also fixes a PHPCS complaint regarding
preg_quote()
not having an explicit$delimiter
set.