Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog when leaving invalid URL screen with unsaved changes #1414

Merged
merged 2 commits into from Sep 9, 2018

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented Sep 9, 2018

When a user changes a select dropdown to change a validation error status, and then they try to leave the page without clicking Update (or Forget), this now will appear:

image

Also remove autosave script from being included on the screen.

@westonruter westonruter added this to the v1.0 milestone Sep 9, 2018
@westonruter westonruter requested review from kienstra and amedina Sep 9, 2018
amedina
amedina approved these changes Sep 9, 2018
Copy link
Member

@amedina amedina left a comment

Ship it.

@westonruter westonruter merged commit ee5cf96 into develop Sep 9, 2018
2 checks passed
@swissspidy swissspidy deleted the add/ays branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants