Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation dialog when leaving invalid URL screen with unsaved changes #1414

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Add confirmation dialog when leaving invalid URL screen with unsaved changes #1414

merged 2 commits into from
Sep 9, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Sep 9, 2018 •
edited
Loading

When a user changes a select dropdown to change a validation error status, and then they try to leave the page without clicking Update (or Forget), this now will appear:

image

Also remove autosave script from being included on the screen.

@westonruter westonruter added this to the v1.0 milestone Sep 9, 2018
@westonruter westonruter mentioned this pull request Sep 9, 2018
Merged
amedina
amedina approved these changes Sep 9, 2018
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@westonruter westonruter merged commit ee5cf96 into develop Sep 9, 2018
@swissspidy swissspidy deleted the add/ays branch June 18, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

@kienstra kienstra Awaiting requested review from kienstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@westonruter @amedina