New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error listing view - make details column unsortable #1444

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@johnwatkins0
Contributor

johnwatkins0 commented Sep 19, 2018

This resolves a loose end in #1361. Originally the "Details" column was to be sortable, but after #1361 was merged, @westonruter suggested (on Slack) that column not be sortable because of the different types of data that may be shown there. This makes the column unsortable.

@johnwatkins0 johnwatkins0 requested review from westonruter and kienstra Sep 19, 2018

@westonruter westonruter added this to the v1.0 milestone Sep 19, 2018

@westonruter westonruter merged commit 3bed87c into develop Sep 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the update/1361-unsortable-details-column branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment