Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native/paired/classic mode to AMP generator meta #1465

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@westonruter
Copy link
Member

westonruter commented Sep 25, 2018

In order to track the success of the new AMP theme support (in native and paired modes) over the classic mode, it is important to capture whether the new paired or native modes are in use. This PR adds a mode param to the meta generator tag:

<meta name="generator" content="AMP Plugin v1.0-beta4; mode=native">
<meta name="generator" content="AMP Plugin v1.0-beta4; mode=paired">
<meta name="generator" content="AMP Plugin v1.0-beta4; mode=classic">

westonruter added some commits Sep 25, 2018

@westonruter westonruter added this to the v1.0 milestone Sep 25, 2018

@westonruter westonruter requested a review from amedina Sep 25, 2018

@amedina
Copy link
Member

amedina left a comment

Ship it!

@kienstra

This comment has been minimized.

Copy link
Collaborator

kienstra commented Sep 27, 2018

Approved

Hi @westonruter,
To echo @amedina's point, this looks good.

The <meta name="generator" ...> tag appears as expected in all 3 template modes:

Native mode:
native-mode

Paired mode:
paired-mode

Classic mode:
classic-mode

@westonruter westonruter merged commit 99d0943 into develop Sep 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/meta-generator-mode branch Sep 27, 2018

@kienstra kienstra requested review from kienstra and removed request for kienstra Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.