Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add AMP to embed templates #1466

Closed
wants to merge 1 commit into from
Closed

[WIP] Add AMP to embed templates #1466

wants to merge 1 commit into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Sep 25, 2018 •
edited
Loading

This is a dependency for #809 which will also depend on ampproject/amphtml#18378

  • Ensure required AMP markup is added to embed templates.
  • Force AMP for embed templates even if there are unaccepted errors.

@westonruter westonruter added this to the v1.1 milestone Sep 25, 2018
@westonruter
Copy link
Member Author

Closely related to #1934 which prevented AMP from being served in embed templates.

I'm not sure if this PR here is even a correct approach now.

@westonruter westonruter removed this from the v1.1 milestone Mar 14, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 14, 2019
@swissspidy swissspidy added the Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 14, 2019
@swissspidy
Copy link
Collaborator

Closing in favor of #3465

@swissspidy swissspidy closed this Oct 14, 2019
@schlessera schlessera deleted the add/post-embed-template branch March 7, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Stale Gives the original author opportunity to update before closing. Can be reopened as needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westonruter @swissspidy @googlebot