Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec from revision 720 to 734 #1475

Merged
merged 1 commit into from Sep 27, 2018
Merged

Update spec from revision 720 to 734 #1475

merged 1 commit into from Sep 27, 2018

Conversation

@kienstra
Copy link
Contributor

@kienstra kienstra commented Sep 27, 2018

  • Updates the AMP spec, simply from running bash bin/amphtml-update.sh
  • No other edits
  • Basic testing of this looks good so far, but we'll need full end-to-end testing, just like with any release
Run bash bin/amphtml-update.sh
In order to update the plugin to the latest spec.
@kienstra
Copy link
Contributor Author

@kienstra kienstra commented Sep 27, 2018

Request For Review

Hi @westonruter,
Could you please review this?

@kienstra kienstra requested a review from westonruter Sep 27, 2018
@westonruter westonruter added this to the v1.1 milestone Sep 27, 2018
@westonruter westonruter removed this from the v1.1 milestone Sep 27, 2018
@westonruter westonruter added this to the v1.0 milestone Sep 27, 2018
@westonruter westonruter merged commit fc7e255 into develop Sep 27, 2018
2 checks passed
@westonruter westonruter deleted the update/amp-spec-734 branch Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants