Amend AMP style elements with sourceURL comment for DevTools #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved Hi @westonruter, Just like your screenshot above, I also saw that the coverage appears for
|
kienstra
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stylesheets include a
sourceURLcomment at the end then they will be listed in DevTools as sources which can by analyzed for CSS code coverage:This change is important because it allows developers to identify which CSS rules specifically need to be removed. As discussed in #1583, the CSS tree shaker in the plugin is not able to be very sophisticated in how deeply it shakes the tree because it must be done at runtime.
So this relates to #1583, but it re-uses DevTools to do the code coverage instead of having to re-implement the functionality on the PHP side. This is not a replacement, however, because the code coverage does not indicate the specific stylesheet sources for where the unused CSS rules are coming from.
Thanks to @paulirish for the tip.