Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AMP Settings in editor to after default settings #1652

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

miina
Copy link
Contributor

@miina miina commented Nov 26, 2018

Fixes #1645.

@westonruter westonruter added this to the v1.0 milestone Nov 26, 2018
@miina
Copy link
Contributor Author

miina commented Nov 26, 2018

@westonruter This moves the AMP controls after the default controls in the sidebar.

However, one note about Gallery and Image blocks -- when these blocks are not populated with image(s) they don't show the default controls. The default controls will be added once an image has been added and it looks like the controls are then added to the end of the existing controls.

This means that if an image has been added and the editor would select the block then the default controls show first. However, if the image has not been added yet and gets added then the newly added Image controls seem to be added to the end thus having the AMP Controls first. It will display correct order after selecting another block for a moment or saving / refreshing the page.

Would this be sufficient to fix #1645? Thoughts?

@westonruter
Copy link
Member

I think so, yes.

@westonruter westonruter merged commit dffc1f9 into 1.0 Nov 26, 2018
@westonruter westonruter deleted the 1645-move_amp_controls branch November 26, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants