Address an issue with an invalid embed #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theme This might not be the right approach, but this addresses an issue that Tonya found in testing this with the Essence Pro (Genesis) theme. Genesis has a function genesis_do_post_content() that calls the_content(). So if an embed in the post content has a validation error, the theme will be reported as a source of a validation error. So this outputs the theme as a source only if there's no embed source of the validation error.
westonruter
approved these changes
Nov 27, 2018
|
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps To Reproduce
the_contentinside a function, like the Genesis theme Essence Prohttps://www.ted.com/talks/derek_sivers_how_to_start_a_movement
7. Actual: The theme is reported as the sourceThanks to @hellofromtonya for reporting this.
The Genesis theme has a function
genesis_do_post_content()that callsthe_content():...so it was reported as the source.
Still, I'm not sure this PR's approach is right.