Resizable iframes #2340
Closed
Resizable iframes #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swissspidy If an See the §Resizing |
|
Somehow I didn't find #914, #809, nor ampproject/amphtml#18378 🤦♂ Glad to hear this has been previously been brought up. |
Nice that #2712 is aiming to fix that. |
|
Closing for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the AMP plugin supports many different embed providers, WordPress does not appear to be one of them.
This PR tries to improve this, so that Story embeds can also use iframes.
Fixes #2301.