Update amphtml spec to ed0504b #6436
Conversation
westonruter
changed the title
westonruter
force-pushed
the
update/amphtml-2106290147000
branch
from
aa779f4
to
e99b8de
Compare
|
Plugin builds for d05beb7 are ready 🛎️!
|
| 'attr_spec_list' => array( | ||
| 'data-src' => array( | ||
| 'mandatory' => true, | ||
| 'value_regex' => '\\d', |
There was a problem hiding this comment.
You found a bug!
Check out how what is supposed to be valid is invalid in the AMP Playground.
Nevertheless, the component initializes properly. To make it valid, I have to reduce the data-src to one single digit. See example.
Clearly this is wrong, as then the component fails to initialize.
I've opened ampproject/amphtml#35329 to fix this.
There was a problem hiding this comment.
I knew something was up! But I was pondering on how such a bug could slip through, as I thought that the tests would've caught something like that.
|
When is the next spec + plugin update planned after this? ampproject/amphtml#35436 just got fixed in AMP and I'd love to include that in the Web Stories plugin in a month or so. |
|
@swissspidy It's currently blocked by ampproject/amphtml#35329. Once that is merged we can do a 2.1.4 release next week. |
|
So any chance ampproject/amphtml#35436 could be included in that update as well? |
|
Yes, I'll make sure I update to the latest spec before merging. |
westonruter
changed the title
westonruter
force-pushed
the
update/amphtml-2106290147000
branch
from
f8e0a3e
to
d05beb7
Compare
|
QA Passed I added the following to a Custom HTML block: <amp-tiktok layout="responsive" height="575" width="325" data-src="https://www.tiktok.com/@scout2015/video/6718335390845095173">
<blockquote class="tiktok-embed" cite="https://www.tiktok.com/@scout2015/video/6718335390845095173" data-video-id="6718335390845095173" placeholder>
<section> <a target="_blank" title="@scout2015" href="https://www.tiktok.com/@scout2015">@scout2015</a>
<p>Scramble up ur name & I’ll try to guess it😍❤️ <a title="foryoupage" target="_blank" href="https://www.tiktok.com/tag/foryoupage">#foryoupage</a> <a title="PetsOfTikTok" target="_blank" href="https://www.tiktok.com/tag/PetsOfTikTok">#petsoftiktok</a> <a title="aesthetic" target="_blank" href="https://www.tiktok.com/tag/aesthetic">#aesthetic</a></p>
<p> <a target="_blank" title="♬ original sound - tiff" href="https://www.tiktok.com/music/original-sound-6689804660171082501">♬ original sound – tiff</a> </p></section>
</blockquote>
</amp-tiktok>It appeared on a post without any validation error:
|
Previously #6425.
./bin/amphtml-update.sh(lando ssh -c 'bash ./bin/amphtml-update.sh vendor/amphtml').Update spec generator as needed based on spec format changes.Modify validating sanitizer based on changes to spec, if needed.Changelog
amp-tiktokcomponent. This is a dependency for Update the TikTok embed handler to useamp-tiktokcomponent #6060.Blocked by 🐛 Fixvalue_regexforamp-tiktok@data-srcto allow repeating digits and a TikTok URL amphtml#35329.amp-wordpress-embedcomponent. See Intent to Implement: <amp-wordpress-embed> Embedding WordPress Posts amphtml#18378 and ✨Bentoamp-wordpress-embedamphtml#34948. This was a long-standing dependency for Improve handling of WordPress post embeds #809. 🎉amp-google-assistant-*components.amp-soundcloud1.0 as a valid version (Bento).amp-embedly-card1.0 as a valid version (Bento).amp-facebook-like.amp-lightbox-gallery1.0 as valid version (Bento).amp-story-interactive-img-quiz,amp-story-interactive-img-poll.feblendSVG element.atags amphtml#35067.captureattribute toinputelement.Details
( PREV_VERSION=2106240350000; THIS_VERSION=ed0504b; git checkout $THIS_VERSION; git diff $PREV_VERSION...$THIS_VERSION -w -- $( git ls-files | grep '.protoascii' ); git checkout - > /dev/null )