Revert #725: Abstract notion of AMP Actions #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
revert/amp-actions-abstraction
branch
from
0300898
to
13bbfab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the work being done on canonical AMP support for themes in #857, the changes in #725 turned out to not be the route we decided on. Instead of fleshing out the plugins AMP post template system, we're going the route of re-using native WordPress theme templates and then just turning off or replacing actions that aren't compatible with AMP, and then adding filters to ensure content is output as valid AMP with final output buffering to ensure that all of the required AMP component scripts are included.
This reverts commit c5237e6, reversing changes made to 41af096.
Fixes merge conflicts introduced by #810 and #828. It back-ports the improvements to phpdoc and coding standards.