Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap on anchor elements inside amp-lightbox element doesn't work #1274

Closed
YukiYamashina opened this issue Dec 30, 2015 · 3 comments
Closed

Tap on anchor elements inside amp-lightbox element doesn't work #1274

YukiYamashina opened this issue Dec 30, 2015 · 3 comments
Assignees

Comments

@YukiYamashina
Copy link

I try to create web page with a menu button, tapping which opens a menu window, using AMP HTML. amp-lightbox is used to show such a window, something like

<amp-lightbox id="open-menu" layout="no display">
  <nav><ul>
    <li><a href="//www.google.com/">Google</a></li>
  </ul></nav>
</amp-lightbox>

<button on="tap:open-menu">MENU<button>

Although the "click" does work (jump to a href page), "tap" does not work (the window close and no jump). Is it possible to fix this such that tap events on anchor element inside an amp-lightbox element trigger a jump to a href page?

Here is an example page (tap "MENU" at top right corner and tap some menu).

@dvoytenko
Copy link
Contributor

/cc @sriramkrish85 didn't we fix this or attempted to do so?

@rudygalfi
Copy link
Contributor

@sriramkrish85 Since #1327 was merged, is this resolved?

@camelburrito
Copy link
Contributor

yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants