Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Function declarations using lowercase 'function' instead of 'Function' #1275

Closed
camelburrito opened this issue Dec 30, 2015 · 3 comments

Comments

@camelburrito
Copy link
Contributor

difference between {function()} and {Function}. The latter is an instance type and is nullable by default. function(...) should be used instead of Function whenever possible because it provides more type information about its parameters and return value.

unless we do
var x = new Function(), we should always use lowercase 'functions' in typedefs and annotations.

@Lillian-wang
Copy link
Contributor

Hi @camelburrito, I am looking into this bug. So I will update the JS docs for the file in the AMP project. Other than the third_party folder, are there any other folders I should make sure to avoid touching?
Thanks!

@camelburrito
Copy link
Contributor Author

You would be only modifying code annotation (JS docs), so you can touch anything. When you are done run gulp type-check to make sure there are no type check errors ! Thanks for fixing.

@adelinamart
Copy link
Contributor

this was fixed accordingly to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants