Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<amp-video> DOM is mutated by two unknowing modules #13673

Closed
3 tasks
alanorozco opened this issue Feb 26, 2018 · 6 comments
Closed
3 tasks

<amp-video> DOM is mutated by two unknowing modules #13673

alanorozco opened this issue Feb 26, 2018 · 6 comments
Assignees
@alanorozco
Labels
P2: Soon Stale Inactive for one year or more Type: Bug WG: components WG: stories
Milestone
Backlog Bugs

Comments

@alanorozco
Copy link
Member

alanorozco commented Feb 26, 2018 •
edited
Loading

<amp-video> content is being manipulated by AmpVideo (component implementation) and MediaPool.

Execution control should be inverted so that AmpVideo provides component configuration to MediaPool through a clear interface.

Sibling issue for video refactoring: #13674

  • Create a sane API for rewriting automatic playback policies. (Part of Video API components can't opt out of behaviors #13674)
  • Invert MediaPool control so that components provide their required children and props (access to <video> is scoped.)
  • Refactor amp-video so that it can fork into two playback bindings (normal, mediapool).

/cc @newmuis @aghassemi
@alanorozco alanorozco added this to the Sprint H2 February milestone Feb 26, 2018
@alanorozco alanorozco self-assigned this Feb 26, 2018
@alanorozco alanorozco mentioned this issue Feb 26, 2018
Closed
@alanorozco alanorozco mentioned this issue Mar 5, 2018
Closed
@alanorozco alanorozco mentioned this issue Mar 16, 2018
Closed
3 tasks
@alanorozco alanorozco changed the title <amp-video> DOM content is being mutated by two independent components <amp-video> DOM is mutated by two independent components Mar 16, 2018
@alanorozco alanorozco changed the title <amp-video> DOM is mutated by two independent components <amp-video> DOM is mutated by two unknowing modules Mar 16, 2018
This was referenced Mar 17, 2018
Closed
Closed
@alanorozco alanorozco mentioned this issue Mar 29, 2018
Closed
4 tasks
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @alanorozco Do you have any updates?

@newmuis newmuis mentioned this issue Nov 30, 2018
Closed
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @alanorozco Do you have any updates?

@alanorozco
Copy link
Member Author

Being dealt with separately, see #19510.

@newmuis
Copy link
Contributor

newmuis commented Dec 19, 2018

@alanorozco don't we still need this to track the work being done in #19510, as well as the pending stories change to use getMediaReference()?

@alanorozco
Copy link
Member Author

Let's keep it open.

@alanorozco alanorozco reopened this Jan 8, 2019
@newmuis newmuis mentioned this issue Jan 15, 2019
Closed
13 tasks
@stale
Copy link

stale bot commented Dec 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 31, 2020
@stale stale bot closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanorozco alanorozco

Labels
P2: Soon Stale Inactive for one year or more Type: Bug WG: components WG: stories
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
5 participants
@alanorozco @newmuis @aghassemi @dreamofabear @ampprojectbot