Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp story shopping] Build shopping CTA #36697

Closed
processprocess opened this issue Nov 1, 2021 · 0 comments · Fixed by #36721
Closed

[amp story shopping] Build shopping CTA #36697

processprocess opened this issue Nov 1, 2021 · 0 comments · Fixed by #36721
Assignees
@processprocess
Labels
P1: High Priority Type: Feature Request WG: stories
Projects
wg-stories Shopping wg-stories Sprint

Comments

@processprocess
Copy link
Contributor

processprocess commented Nov 1, 2021 •
edited
Loading

Description

  1. Render a CTA on pages with the amp-story-shopping-attachment. This could happen here and here

It is okay for it to display the default "Swipe up" text. A follow up PR #36698 will set the text.
Screen Shot 2021-11-02 at 10 34 40 AM

  1. Ensure setting a theme attribute works on the CTA.
  2. Add a visual diff test.
@processprocess processprocess added this to To do in wg-stories Shopping via automation Nov 1, 2021
@processprocess processprocess added this to To do in wg-stories Sprint via automation Nov 2, 2021
@processprocess processprocess moved this from To do to In progress in wg-stories Shopping Nov 2, 2021
@processprocess processprocess moved this from To do to In progress in wg-stories Sprint Nov 2, 2021
@processprocess processprocess mentioned this issue Nov 2, 2021
Merged
wg-stories Sprint automation moved this from In progress to Done Nov 3, 2021
wg-stories Shopping automation moved this from In progress to Done Nov 3, 2021
@newmuis newmuis mentioned this issue Nov 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@processprocess processprocess

Labels
P1: High Priority Type: Feature Request WG: stories
Projects
wg-stories Shopping
Done
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Render page level CTA when amp-story-shopping-attachment exists processprocess/amphtml
2 participants
@processprocess @jshamble