Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Lazily build JS during default gulp task #24199

Merged
merged 2 commits into from Aug 25, 2019
Merged

馃彈 Lazily build JS during default gulp task #24199

merged 2 commits into from Aug 25, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Aug 24, 2019

#24152 added a way to lazily build extensions during the default gulp task. This PR goes a step further, and lazily builds all JS (except for the core runtime amp.js, which is eagerly built).

Usage:

gulp --lazy_build

Highlights:

  • Removed all hardcoded compileJs calls in build-system/tasks/helpers.js
  • Added several js target definitions to bundles.config.js
  • Refactored JS building into a new function called doBuildJs()
  • Added a new server module build-system/lazy-build.js to build JS and extensions
  • Refactored performBuild() in build-system/tasks/build.js
  • Refactored dist() in build-system/tasks/dist.js
  • Assorted documentation / logging / clean up

Coming up:

Partially addresses #24152 (review)
Partial fix for #24141
Follow up to #24138 and #24152

@rsimha rsimha requested a review from cramforce August 24, 2019 23:44
@rsimha rsimha self-assigned this Aug 24, 2019
Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

build-system/tasks/build.js Outdated Show resolved Hide resolved
@rsimha rsimha changed the title 馃彈 Lazily build runtime targets during default gulp task 馃彈 Lazily build runtime JS during default gulp task Aug 25, 2019
@rsimha rsimha changed the title 馃彈 Lazily build runtime JS during default gulp task 馃彈 Lazily build JS during default gulp task Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants