New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃彈 Re-implement gulp serve
as an in-process server
#24325
Conversation
gulp serve
as an in-process server using gulp-connect
gulp serve
as an in-process server
Travis checks are green, and I've tested this in a few different ways. Adding some folks for extra review to spot corner cases that might need follow up fixes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rsimha for improve the server : ) LGTM 馃憤
Also talked offline, we will need to further improve the app.js
code as now the file is getting too big. And the order of the proxy could lead to issues.
For example here: the no-caching-extensions
option. Because it's placed at line 843, when we fetched something like /dist/rtv/*/v0/*.js
, it won't be applied because of the order.
Or, setHeader()
that's placed after the proxy could change the header value.
Also agreed on all request related middleware should go to app.js, while server setting related middleware should go to serve.js.
PR Highlights:
nodemon
+gulp-webserver
(hasn't been updated in 4 years)gulp-connect
(updated more recently)amp.js
in non-default modesgulp
task聽#24152 (comment) (need to set args inargv
and inprocess.env
)gulp --lazy_build
聽#24287 (comment) (unnecessary env vars inserver.js
)Coming up:
Partial fix for #24141
Related to #16643, #18635, #24138, #24152, #24199, #24214, #24258, #24244, #24287