馃彈 Wait on pending builds during gulp --lazy_build
#24214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, if a test webpage requests a JS file more than once during
gulp --lazy_build
, concurrent builds are triggered for the same file, leading to a race.This PR eliminates the race as follows:
doBuildJs()
to match that ofdoBuildExtension()
lazyBuildExtensions()
andlazyBuildJs()
into a helper functionlazyBuild()
that calls the correct build function if necessarylazyBuild()
to keep track of and wait for pending builds before servingThis implements the "luxury" version of lazy building mentioned in #24138 (review)
Addresses #24141 (comment)
Partial fix for #24141
Follow up to #24138, #24152, and #24199