✨ amp-story-desktop-one-panel Background blur MVP
#34974
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
| * @return {?Element} An img element or null. | ||
| */ | ||
| getBiggestImage_(pageElement) { | ||
| const getSize = (el) => el && el.offsetWidth * el.offsetHeight; |
There was a problem hiding this comment.
Love this solution of getting the biggest img!
The one worry I have is offsetWidth/Heigh triggering relayout/paint.
To work around it, I suggest we query the amp-img instead of the img, and use getLayoutBox() that returns cached measurements from the AMP runtime.
There was a problem hiding this comment.
Looks like getLayoutBox is being deprecated and checks wont pass with it:
https://app.circleci.com/pipelines/github/ampproject/amphtml/12123/workflows/fbc193e8-aff0-49b9-89d5-081efcc40a61/jobs/193397?invite=true#step-111-99
I2D:
#31540
I wonder what a good alternative would be.
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
|
cc @rsimha for OWNERS on |
ghost
mentioned this pull request
Contributes to #34764
Fixes #34960 #34967 #34962 #34959
An
AmpStoryBackgroundBlurclass with MVP methods.Demo