Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-story-desktop-one-panel blurred background, get largest page image #34959

Closed
processprocess opened this issue Jun 22, 2021 · 0 comments
Closed

amp-story-desktop-one-panel blurred background, get largest page image #34959

processprocess opened this issue Jun 22, 2021 · 0 comments
Assignees
@processprocess
Labels
P2: Soon Type: Feature Request WG: stories

Comments

@processprocess
Copy link
Contributor

Description

Get image on page that is intended to be a background image.
This could default to the story poster image for all pages.

This could be based on the legacy method

Alternatives Considered

  1. We could only trigger this if there is a [template="fill"]:not(.i-amphtml-hidden-by-media-query) img element.
  2. We could only trigger this if there is a [template="fill"]:not(.i-amphtml-hidden-by-media-query) img element.
  3. In addition, we could default to the background color of the amp-story-page, this might not always look good though because we will add a 70% black overlay.

Additional Context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@processprocess processprocess

Labels
P2: Soon Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@processprocess