New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚮 Remove experiment amp-consent-granular-consent
#35508
Merged
alanorozco
merged 4 commits into
ampproject:main
from
alanorozco:granular-consent-experiment
Aug 3, 2021
Merged
🚮 Remove experiment amp-consent-granular-consent
#35508
alanorozco
merged 4 commits into
ampproject:main
from
alanorozco:granular-consent-experiment
Aug 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous history on prod-config.json: - db781bd - 2021-03-17T09:35:48-07:00 - turnOnGranularConsent
Sweep experiments last flipped globally up to 2021-07-27: - (2021-03-17, db781bd) `amp-consent-granular-consent`: 1 --- ###⚠️ Javascript source files require intervention The following may contain errors and/or require intervention to remove superfluous conditionals: - [ ] `extensions/amp-consent/0.1/amp-consent.js` - [ ] `extensions/amp-consent/0.1/consent-ui.js` - [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js` - [ ] `extensions/amp-consent/0.1/test/test-consent-ui.js` - [ ] `src/custom-element.js` - [ ] `test/unit/test-custom-element.js` Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/main/build-system/tasks/sweep-experiments/README.md#followup) --- ###⚠️ HTML files may still contain references The following HTML files contain references to experiment names which may be stale and should be manually removed: - [ ] `test/manual/amp-consent/amp-consent-granular-consent.html` Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/main/build-system/tasks/sweep-experiments/README.md#followup:html)
dmanek
approved these changes
Aug 3, 2021
alanorozco
requested review from
kristoferbaxter
and removed request for
cramforce
August 3, 2021 18:30
kristoferbaxter
approved these changes
Aug 3, 2021
caroqliu
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this PR also close #31607?
@caroqliu The tracker includes an item for E2E tests that have not been added. It's unclear to me whether we need them still. |
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 3, 2021
…tok-validation * 'main' of github.com:ampproject/amphtml: (72 commits) build: run amp lint --fix to address import order of jixie (ampproject#35513) ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193) babel: teach amp mode transformer about #core/mode (ampproject#35477) 🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508) ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454) 🐛 [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449) ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450) 🐛 Fix error on bento example (ampproject#35490) 🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503) 🐛 Fix code formatting (ampproject#35499) ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494) ♻️ Remove unused imports (ampproject#35435) ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179) Updated document with use cases of remote config (ampproject#35496) AMP.goBack: update documentation (ampproject#29290) 🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492) build-system: improve terser/esbuild integration (ampproject#35466) 🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476) 📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338) 🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375) ...
alanorozco
added a commit
that referenced
this pull request
Aug 4, 2021
I should have done this as part of #35508 Also formatted file, and removed unused extension script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for #31607