Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [amp-render] fix root-element stripping from amp-render with amp-bind #35449

Merged
merged 12 commits into from
Aug 3, 2021
Merged

🐛 [amp-render] fix root-element stripping from amp-render with amp-bind #35449

merged 12 commits into from
Aug 3, 2021

Conversation

dmanek
Copy link
Contributor

@dmanek dmanek commented Jul 28, 2021 •
edited
Loading

Fixes #35401

@dmanek dmanek changed the title fix <ul> stripping from amp-render with amp-bind 🐛 [amp-render] fix <ul> stripping from amp-render with amp-bind Jul 29, 2021
@dmanek dmanek marked this pull request as ready for review July 29, 2021 22:11
@dmanek dmanek requested a review from alanorozco July 29, 2021 22:11
@alanorozco alanorozco changed the title 🐛 [amp-render] fix <ul> stripping from amp-render with amp-bind 🐛 [amp-render] fix root-element stripping from amp-render with amp-bind Aug 2, 2021
alanorozco
alanorozco reviewed Aug 2, 2021
View reviewed changes
extensions/amp-render/1.0/amp-render.js Outdated Show resolved Hide resolved
extensions/amp-render/1.0/amp-render.js Show resolved Hide resolved
extensions/amp-render/1.0/amp-render.js Outdated Show resolved Hide resolved
@dmanek dmanek requested a review from alanorozco August 3, 2021 05:27
@dmanek dmanek merged commit 99d06c5 into ampproject:main Aug 3, 2021
@dmanek dmanek deleted the issue-35401 branch August 3, 2021 17:36
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 3, 2021
@westonruter
Merge branch 'main' of github.com:ampproject/amphtml into fix/amp-tik…
18af678 
…tok-validation

* 'main' of github.com:ampproject/amphtml: (72 commits)
  build: run amp lint --fix to address import order of jixie (ampproject#35513)
  ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193)
  babel: teach amp mode transformer about #core/mode (ampproject#35477)
  🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508)
  ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454)
  🐛  [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449)
  ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450)
  🐛 Fix error on bento example (ampproject#35490)
  🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503)
  🐛 Fix code formatting (ampproject#35499)
  ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494)
  ♻️ Remove unused imports (ampproject#35435)
  ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179)
  Updated document with use cases of remote config (ampproject#35496)
  AMP.goBack: update documentation (ampproject#29290)
  🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492)
  build-system: improve terser/esbuild integration (ampproject#35466)
  🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476)
  📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338)
  🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375)
  ...
This was referenced Aug 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-bind clashes with amp-render and Mustache templates
3 participants
@dmanek @alanorozco @ampprojectbot