Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added initial version of amp-anlaytics variable filters." #6542

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

avimehta
Copy link
Contributor

@avimehta avimehta commented Dec 7, 2016

Reverts #5621

Found a bug in the change. We use object.hasOwnProperty on objects created using map()

@jridgewell
Copy link
Contributor

It'd be better to use:

// module level hoist
const hasOwn = Object.prototype.hasOwnProperty;

// wherever we need to check
if (hasOwn.call(object, property)) {
}

@avimehta
Copy link
Contributor Author

avimehta commented Dec 8, 2016

Added #6552 as an alternative. Since the release will be getting cut shortly, I am okay with either of the PRs getting merged.

@avimehta avimehta merged commit f6fe757 into master Dec 8, 2016
@avimehta avimehta deleted the revert-5621-filters branch January 6, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants