Skip to content

2001071857360
Compare
Choose a tag to compare
@ampprojectbot ampprojectbot released this 10 Jan 19:55
2001071857360
940285e
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Version: 2001071857360

Baseline: 1912180046560

  • Add issue number to amp fie experiment cleanup comment (#26227)
  • Always return cookie from origin if exist (#26130)
  • 🐛Fix ad request logic in stories (#26208)
  • Fix analytics examples (#26213)
  • ♻️ Run prettier on amp.extern.js (#26202)
  • Fix the targetId finder for position-observer in friendly iframe (#26129)
  • 📖 Add note in experiments page about blocking third-party cookies (#26045)
  • Update README.md (#24964)
  • 🏗 Make Closure import "module" field (#26123)
  • Support Ctrl + Enter to submit a form within a <textarea> (#26152)
  • SwG release 0.1.22.88 (#26222)
  • Cta-layer typo fix (#26218)
  • Cleanup the amp-nested-menu experiment (#25517)
  • 📦 Update dependency globby to v11 (#26217)
  • Vdo.ai (#26102)
  • ✨ Add inactive event types to amp-analytics (#26115)
  • ✨ SwG: Propensity to Subscribe in AMP (#26003)
  • 🐛 Fix amp-list race condition (#25964)
  • 📦 Update dependency sinon to v8.0.2 (#26169)
  • 📦 Update dependency magic-string to v0.25.5 (#26194)
  • 📦 Update dependency escodegen to v1.12.1 (#26198)
  • Adding amp-geo url-replacement test coverage (#26126)
  • Add wg-analytics to cid service owners (#26193)
  • 📦 Update dependency eslint-plugin-jsdoc to v18.11.0 (#26164)
  • Whitelist amp-list's [is-layout-container] in AMP for Email (#26168)
  • ♻️ Refactor bind.setState and bind.apply to take in an options bag. (#26067)
  • Allow 2020 in copyright declaration (#26189)
  • 🖍Add animation to story quiz option selection (#25984)
  • 📦 Update dependency postcss to v7.0.26 (#26174)
  • ✨Create Analytics event to capture quiz responses (#26072)
  • Change progress bar resize delay. (#26005)
  • 🚮 Remove remnants of multi-consent experiment (#26161)
  • 📦 Update dependency eslint to v6.8.0 (#26125)
  • Variant error message (#26153)
  • 📦 Update dependency babel-plugin-istanbul to v6 (#26133)
  • 📦 Update dependency eslint-config-prettier to v6.9.0 (#26149)
  • 📦 Update dependency eslint-plugin-jsdoc to v18.6.0 (#26134)
  • 📦 Update dependency sinon to v8 (#26132)
  • 📦 Update dependency fetch-mock to v8.2.1 (#25884)
  • 📦 Update dependency postcss to v7.0.25 (#26043)
  • 📦 Update dependency sinon-chai to v3.4.0 (#26144)
  • 🐛amp-form: Parse JSON string in SSR response['body'] (#26117)
  • Move basic A4A amp-bind test to e2e test. (#26141)
  • Validator rollup 20191223 (#26140)
  • Update Selenium version (#25939)
  • Fix: amp-sticky-ad made visible for AdSense no fill case (#26119)
  • Allow chrome protocol to A href (#26138)
  • Fix: amp-position-observer fails to detect movement in friendly iframe (#26095)
  • 📦 Update dependency typescript to v3.7.4 (#26127)
  • 📦 Update dependency eslint-plugin-chai-expect to v2.1.0 (#25932)
  • 🏗 Upgrade com.puppycrawl.tools:checkstyle to 8.18 (#26124)
  • 📦 Update dependency terser to v4.4.3 (#26048)
  • 📦 Update dependency eslint-plugin-prettier to v3.1.2 (#26031)
  • 🏗 Add a --coverage flag to gulp build to instrument the u… (#26028)
  • 📦 Update dependency typescript to v3.7.3 (#25864)
  • Improve amp-consent e2e (#26112)
  • amp-script: Remove height constraint for mutation (#26066)
  • prefer .getAttribute over direct property access, since only some dom emulators recognize it (fixes saucelabs)
  • Disallow redirect on amp-form submission in AMP4Email (#26108)
  • Modifying AMP Auto Ads so that the ad stratgies still run even if there is a noConfigReason (#26116)
  • Add an exceptional case for the deprecation process (#25002)
  • Modifying AMP Auto Ads to run strategies even if noConfigReason present (#26116)
  • 🐛 Metering viewer fix (#26110)
  • 🐛Don't request story ad in short stories. (#26096)
  • 📦 Update babel monorepo to v7.7.7 (#26097)
  • ♻️ Refactors visibility observing in amp-next-page v2 (#26032)
  • 📦 Update dependency lolex to v5.1.2 (#26101)
  • Remove experiment (#26063)
  • Enable ANALYTICS_VENDOR_SPLIT experiment, add new tests (#26055)
  • ♿Replace i-amphtml-screen-reader usage on amp-carousel 0.1 (#26069)
  • Add FIE visual tests for amp-ad (#26071)
  • ♻️ amp-story-quiz: fix small gcc type warning (#26086)
  • Skip flakey amp-consent e2e (#26089)
  • Remove 'canary' perf experiment (#26065)
  • cl/286269591 AMP respect different varieties of lightning bolt. (#26094)
  • 📦 Update dependency @percy/agent to v0.20.6 (#26090)
  • Snowplow v2 (#26059)
  • a4a envelopes: (mock) mraid envelope, and no host script if friendly (#24663)
  • Generate analytics vendor configs in singlepass (#26075)
  • 🏗 Handle missing decrypted document key correctly (#25829)
  • Validator 20191218 (#26084)
  • Allow setting RTV experiment flag to custom value (#26054)
  • Check in all analytics config in json (#26053)
  • cl/285484769 Revision bump for #25798 (#26083)
  • load script inside #c container (#23247)
  • Amp-consent e2e (#26013)
  • ✨ amp-story: Add support for a viewer to tell the AMP story to switch pages (#26007)
  • 🐛Fix test failure (#26073)
  • ✨Add inline-gallery thumbnails element. (#26011)
  • swg release (#26062)
  • 🐛 Fix gulp changelog (#26068)
  • Report dev error at viewer channel timeout (#25931)
  • ✨ Support and prefer Object Spread syntax (#26057)
  • Introduce Largest Contentful Paint tick event (#24346)
  • ✨ Validator support for transformed intrinsic layout (#24119)
  • 🐛 Fixed first contentful paint race condition (#25259)
  • 🐛Fix next/prev arrows being clickable with hidden controls for amp-base-carousel (#25955)
  • ✨amp-next-page v2 history manipulation (#25971)
  • Remove unnecessary lpdid script loading (#25943)
  • 🐛 Fix simple-object-destructure transform for check-types (#26010)
  • Treat amp-script AMP.setState as high trust (#26001)
  • Added new ad network: Nativery (#25207)
  • Add support for Sklik SSP amp-ad (#25637)
  • 📖Documents existing analytics triggers on amp-next-page (#26008)
  • Promote native buyflow to 100% for SwG in AMP (#26021)
  • Updates Design Review guidelines (explainers, deadlines and public requirement) (#25965)
  • ✨ Implementing analytics vendor support for Memo (memo.co) #26000
  • 🐛amp-autocomplete: Require "filter" attribute in validations (#25798)
  • 📖Fix component link s/youtube/story/ (#26017)
  • Cleanup amp-mega-menu experiment (#25488)
  • ID disallowed names (#25993)
  • replace # with & (#25986)
  • 🏗 Don't cache for Travis experiment jobs (#26002)
  • xssi-prefix support to amp-form (#25927)
  • Intent to implement: amp-ad type for AdServSolutions #25806 (#25809)
  • ⏪📖 JW Player: Update documentation and remove configuration options (#25340)
  • ✨Add sizing and positioning constraints to quiz element (#25786)
  • 📦 Update dependency chromedriver to v79 (#25968)
  • Adding sulvo adserver to amp project (#25950)
  • Initial implementation of amp-inline-gallery (#25617)
  • 📦 Update dependency @percy/agent to v0.20.5 (#25983)
  • 🐛Add warning about using GET to send cryptokey (#25849)
  • Validator rollup (#25973)
  • ✨ Add xssiPrefix to amp-consent (#25868)
  • Move calls to mutator interface into a dedicated service (#25904)
  • propagate nonce: update to only document.head (#25970)
  • ♻️ Refactor template helper: Rename isSupported() to isEnabled() (#25948)
  • 🐛 amp-next-page fix interaction with styles (#25959)
  • Moves expect calls to top level (#25788)
  • Ramp layoutbox-invalidate-on-scroll to 10% (#25958)

Breakdown by component

ads Vdo.ai (#26102)
amp-ad Fix: amp-sticky-ad made visible for AdSense no fill case (#26119)
amp-ad-network-adsense-impl Fix: amp-sticky-ad made visible for AdSense no fill case (#26119)
amp-analytics ✨ Add inactive event types to amp-analytics (#26115) Documentation for mentioning WGs (#26156)
amp-auto-ads Fix: amp-sticky-ad made visible for AdSense no fill case (#26119) Modifying AMP Auto Ads to run strategies even if noConfigReason present (#26116)
amp-autocomplete cl/285484769 Revision bump for #25798 (#26083)
amp-bind updated macro code sample to inline executable (#26092)
amp-carousel ♿Replace `i-amphtml-screen-reader` usage on amp-carousel 0.1 (#26069)
amp-consent 🚮 Remove remnants of multi-consent experiment (#26161) Amp-consent value opt-in/opt-out clarification (#26111) Improve amp-consent e2e (#26112) Skip flakey amp-consent e2e (#26089)
amp-form Support Ctrl + Enter to submit a form within a <textarea> (#26152) 📖amp-form renders response via templating provided in any descendent (#26192) 🐛amp-form: Parse JSON string in SSR response['body'] (#26117) Disallow redirect on amp-form submission in AMP4Email (#26108)
amp-lightbox-gallery 🏗 Make Closure import "module" field (#26123)
amp-list Whitelist amp-list's [is-layout-container] in AMP for Email (#26168)
amp-nested-menu 📖 Document `amp-nested-menu` usage in `amp-sidebar` (#26178)
amp-position-observer Add issue number to amp fie experiment cleanup comment (#26227) Fix the targetId finder for position-observer in friendly iframe (#26129) Fix: amp-position-observer fails to detect movement in friendly iframe (#26095)
amp-sidebar 📖 Document `amp-nested-menu` usage in `amp-sidebar` (#26178)
amp-story ✨Create Analytics event to capture quiz responses (#26072) ♻️ amp-story-quiz: fix small gcc type warning (#26086)
amp-story-auto-ads 🐛Fix ad request logic in stories (#26208) 🐛Don't request story ad in short stories. (#26096)
amp-subscriptions Validator rollup 20191223 (#26140) 🐛 Metering viewer fix (#26110)
validator Validator rollup 20191223 (#26140) - cl/286594572 amp-subscriptions - cl/286916651 Revision bump for #26138 Allow chrome protocol to A href (#26138) Fixes #26061

Allows chrome:// protocol in <a href>.
🏗 Upgrade com.puppycrawl.tools:checkstyle to 8.18 (#26124)
This PR fixes the security warning introduced by #25579.

Resolves #25579 (comment)

/cc @GeorgeLuo
cl/286269591 AMP respect different varieties of lightning bolt. (#26094)
Fixes #25990

  • cl/286269591 AMP respect different varieties of lightning bolt.
    Validator 20191218 (#26084)
  • cl/286094937 Allow validator to support LTS release channel for runtime and extensions
  • cl/286215939 Revision bump for #24119

cl/285484769 Revision bump for #25798 (#26083)

  • cl/285484769 Revision bump for #25798
Assets 2