Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce dedicated error types to the lapin-futures crate #145

Merged
merged 5 commits into from
Nov 17, 2018
Merged

Introduce dedicated error types to the lapin-futures crate #145

merged 5 commits into from
Nov 17, 2018

Commits on Nov 17, 2018

  1. Introduce dedicated error types to the lapin-futures crate 

    This change replaces all occurrences of io::Error by the newly created
Error type, the only exception being for AMQPCodec. This change allows
future-proofing the error that can be returned by the crate. For example
by changing the internals of the Error type, it is now possible to
provide users with a way of knowing what kind of error occurred without
having to resort to parsing error messages.

The only exception to this change concerns AMQPCodec: a new Error type
was created just for it because tokio-codec's Encoder and Decoder traits
impose a From<std::io::Error> bound of the error type. Because I didn't
want to introduce a way to create an Error instance from outside the
crate, I isolated the possible errors from this section into its own
type.
    @kureuil
    kureuil committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    b22c23b View commit details
    Browse the repository at this point in the history

  2. Limit conversions to failure::Error in examples 

    Errors are now printed using the `Display` formatter instead of the
`Debug` formatter.
    @kureuil
    kureuil committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    6305ad8 View commit details
    Browse the repository at this point in the history

  3. Display the cause for a GenerationError in AMQPCodec

    @kureuil
    kureuil committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    02a3b0a View commit details
    Browse the repository at this point in the history

  4. Add a changelog entry about the new Error type

    @kureuil
    kureuil committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    f1d327f View commit details
    Browse the repository at this point in the history

  5. Display the cause for a ParseError in AMQPCodec

    @kureuil
    kureuil committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    3148e07 View commit details
    Browse the repository at this point in the history