-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines and annotation docs have different lists of reified concepts #239
Comments
@ULFULF can confirm but I believe the annotation docs are more up-to-date than the guidelines.
|
Thanks for pointing this out. Some of these pairs are valid role/reification pairs, some "roles" are only shortcuts. Valid AMR role/reification pairs:
Not valid AMR roles; used only as shortcuts in the AMR Editor:
Note: The shortcuts' purpose is to make life easier for human AMR annotators. The AMR Editor automatically and instantly expands these shortcuts from pseudo-roles to their AMR reifications. In the table at the bottom of https://www.isi.edu/~ulf/amr/lib/roles.html these were marked as shortcuts Updated: https://github.com/amrisi/amr-guidelines/blob/master/amr.md, https://www.isi.edu/~ulf/amr/lib/roles.html |
Great, thank you for clarifying and for updating the docs and guidelines. While we're on the subject, here are a few more things I noticed (after originally filing this issue):
|
4.5 years later... My question above about I'm not sure about the I'll close this issue. |
The list of reified concepts at https://www.isi.edu/~ulf/amr/lib/roles.html has 7 relation-concept pairs that are not in the list at https://github.com/amrisi/amr-guidelines/blob/master/amr.md#reification:
:cost
cost-01
:employed-by
have-org-role-91
:li
have-li-91
:meaning
mean-01
:ord
have-ord-91
:role
have-org-role-91
:superset
include-91
There is also one pair in the guidelines that's not in the docs:
:value
have-value-91
Should we consider the union of the two lists as the full set?
edit: removed
:time
and:topic
from the first table as they do in fact exist in both placesThe text was updated successfully, but these errors were encountered: